Skip to content

DOC fix numpydoc validation for fetch_kddcup99#23929

Merged
jeremiedbb merged 6 commits intoscikit-learn:mainfrom
DhanshreeA:fix-numpydoc-validation-sklearn.datasets._kddcup99.fetch_kddcup99
Jul 21, 2022
Merged

DOC fix numpydoc validation for fetch_kddcup99#23929
jeremiedbb merged 6 commits intoscikit-learn:mainfrom
DhanshreeA:fix-numpydoc-validation-sklearn.datasets._kddcup99.fetch_kddcup99

Conversation

@DhanshreeA
Copy link
Copy Markdown
Contributor

Addresses #21350

Added documentation for members of the tuple (data, target) which is returned when return_X_y is set.

#europython22

@DhanshreeA
Copy link
Copy Markdown
Contributor Author

@adrinjalali

@adrinjalali adrinjalali changed the title fix numpydoc validation for return_X_y DOC fix numpydoc validation for fetch_kddcup99 Jul 16, 2022
DhanshreeA and others added 3 commits July 16, 2022 17:31
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
Copy link
Copy Markdown
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks @DhanshreeA

@jeremiedbb jeremiedbb merged commit cb8ec24 into scikit-learn:main Jul 21, 2022
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Aug 4, 2022
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
Co-authored-by: jeremiedbb <jeremiedbb@yahoo.fr>
glemaitre pushed a commit that referenced this pull request Aug 5, 2022
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
Co-authored-by: jeremiedbb <jeremiedbb@yahoo.fr>
@DhanshreeA DhanshreeA deleted the fix-numpydoc-validation-sklearn.datasets._kddcup99.fetch_kddcup99 branch October 24, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants