Skip to content

TST Make test_fastica_eigh_low_rank_warning more stable#23770

Merged
jeremiedbb merged 1 commit intoscikit-learn:mainfrom
ogrisel:fix-platform-agnostic-test_fastica_eigh_low_rank_warning
Jun 28, 2022
Merged

TST Make test_fastica_eigh_low_rank_warning more stable#23770
jeremiedbb merged 1 commit intoscikit-learn:mainfrom
ogrisel:fix-platform-agnostic-test_fastica_eigh_low_rank_warning

Conversation

@ogrisel
Copy link
Copy Markdown
Member

@ogrisel ogrisel commented Jun 27, 2022

Fixes #23754.

This test could fail for some random seeds on some platforms.

@ogrisel
Copy link
Copy Markdown
Member Author

ogrisel commented Jun 27, 2022

It passed on all platforms with [all random seeds].

/cc @thomasjpfan.

@ogrisel ogrisel added Build / CI Quick Review For PRs that are quick to review labels Jun 28, 2022
@glemaitre glemaitre changed the title Make test_fastica_eigh_low_rank_warning more stable TST Make test_fastica_eigh_low_rank_warning more stable Jun 28, 2022
Copy link
Copy Markdown
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeremiedbb jeremiedbb merged commit d615633 into scikit-learn:main Jun 28, 2022
ogrisel added a commit to ogrisel/scikit-learn that referenced this pull request Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

⚠️ CI failed on macOS.pylatest_conda_forge_mkl ⚠️

3 participants