Skip to content

CI Do not post again if bot comment already exists#23768

Merged
ogrisel merged 1 commit intoscikit-learn:mainfrom
thomasjpfan:do_not_update_if_success_exists
Jun 27, 2022
Merged

CI Do not post again if bot comment already exists#23768
ogrisel merged 1 commit intoscikit-learn:mainfrom
thomasjpfan:do_not_update_if_success_exists

Conversation

@thomasjpfan
Copy link
Copy Markdown
Member

Reference Issues/PRs

Related to #23754

What does this implement/fix? Explain your changes.

This stops the bot from spamming the issue if the CI is still succeeding. As seen in #23754, the bot does not auto-close the issue because of global_random_seed. In #23754, the CI failed for a specific seed so the issue should remain open.

@thomasjpfan thomasjpfan added the Quick Review For PRs that are quick to review label Jun 27, 2022
@thomasjpfan thomasjpfan changed the title CI Do not post again if CI no longer failing exists CI Do not post again if bot comment already exists Jun 27, 2022
@ogrisel ogrisel merged commit ae7712a into scikit-learn:main Jun 27, 2022
ogrisel pushed a commit to ogrisel/scikit-learn that referenced this pull request Jul 11, 2022
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build / CI Quick Review For PRs that are quick to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants