Skip to content

DOC Added hedonic housing prices to linkcheck_ignore#23763

Merged
lesteve merged 5 commits intoscikit-learn:mainfrom
ikeadeoyin:revert-1-doc-Hedonic_housing_prices
Jun 28, 2022
Merged

DOC Added hedonic housing prices to linkcheck_ignore#23763
lesteve merged 5 commits intoscikit-learn:mainfrom
ikeadeoyin:revert-1-doc-Hedonic_housing_prices

Conversation

@ikeadeoyin
Copy link
Copy Markdown
Contributor

Reference Issues/PRs

Towards #23631

What does this implement/fix? Explain your changes.

The link https://www.researchgate.net/publication/4974606_Hedonic_housing_prices_and_the_demand_for_clean_air modules/generated/sklearn.datasets.load_boston.rst works normally in the browser.
I added this link to linkcheck_ignore

Any other comments?

None

@lesteve
Copy link
Copy Markdown
Member

lesteve commented Jun 28, 2022

Thanks for your PR, the changes look fine in your first commit, but it looks like you have reverted your changes in your last commit, probably that was not intentional?

@lesteve lesteve force-pushed the revert-1-doc-Hedonic_housing_prices branch from b46d6d1 to caf9169 Compare June 28, 2022 06:12
@lesteve
Copy link
Copy Markdown
Member

lesteve commented Jun 28, 2022

I reinstated your changes and fixed the conflicts, merging this one, thanks a lot!

@lesteve lesteve changed the title DOC: Added hedonic housing prices to linkcheck_ignore DOC Added hedonic housing prices to linkcheck_ignore Jun 28, 2022
@lesteve lesteve merged commit af4e342 into scikit-learn:main Jun 28, 2022
ogrisel pushed a commit to ogrisel/scikit-learn that referenced this pull request Jul 11, 2022
)

Co-authored-by: Loïc Estève <loic.esteve@ymail.com>
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Aug 4, 2022
)

Co-authored-by: Loïc Estève <loic.esteve@ymail.com>
glemaitre pushed a commit that referenced this pull request Aug 5, 2022
Co-authored-by: Loïc Estève <loic.esteve@ymail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants