MAINT Use _validate_params in Power and Quantile Transformer#23672
Merged
jeremiedbb merged 7 commits intoscikit-learn:mainfrom Jun 28, 2022
Merged
Conversation
glemaitre
approved these changes
Jun 27, 2022
Member
glemaitre
left a comment
There was a problem hiding this comment.
I removed the tests checking the parameter at transform. If we enforce this checking, it should be done for all estimators.
Otherwise the rest is LGTM.
Member
I'm ok with that |
ogrisel
pushed a commit
to ogrisel/scikit-learn
that referenced
this pull request
Jul 11, 2022
…learn#23672) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
towards #23462
What does this implement/fix? Explain your changes.
_parameter_contraintsinPowerTransformerandQuantileTransformer.self._validate_paramsinfitfunctions.Any other comments?
The test
test_quantile_transform_check_error()fails because it also checks the parameters duringtransformandinverse_transform.I am unsure whether I should remove this test or also callself._validate_paramsintransformandinverse_transform.