DOC Ensures that sklearn.metrics._classification.log_loss passes numpydoc validation#23657
Merged
jeremiedbb merged 7 commits intoscikit-learn:mainfrom Jun 22, 2022
Merged
Conversation
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Contributor
Author
|
Reversed the changes keeping the commit. Don't know if this is a good practise. |
jeremiedbb
reviewed
Jun 22, 2022
Member
Not an issue in scikit-learn since we squash the commits before merging anyway |
ogrisel
pushed a commit
to ogrisel/scikit-learn
that referenced
this pull request
Jul 11, 2022
…ydoc validation (scikit-learn#23657) Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com> Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Aug 4, 2022
…ydoc validation (scikit-learn#23657) Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com> Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
glemaitre
pushed a commit
that referenced
this pull request
Aug 5, 2022
…ydoc validation (#23657) Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com> Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Adress #21350
What does this implement/fix? Explain your changes.
Make sure that the docstring passes the numpydoc test.
Any other comments?
To pass the test I had to add a description of the returned value of the log_loss function. I am not sure if my description, was the most appropriate one. If would by nice to check it. Thanks!