DOC Ensures that sklearn.datasets._lfw.fetch_lfw_pairs passes numpydoc validation#23655
Merged
jeremiedbb merged 2 commits intoscikit-learn:mainfrom Jun 22, 2022
Merged
DOC Ensures that sklearn.datasets._lfw.fetch_lfw_pairs passes numpydoc validation#23655jeremiedbb merged 2 commits intoscikit-learn:mainfrom
jeremiedbb merged 2 commits intoscikit-learn:mainfrom
Conversation
thomasjpfan
reviewed
Jun 21, 2022
Member
thomasjpfan
left a comment
There was a problem hiding this comment.
Thank you for the PR!
As stated in Step 3 in #21350 (comment), may you remove the line here:
so the CI runs the test on fetch_lfw_pairs.
Contributor
Author
|
Sorry, about that. Done |
ogrisel
pushed a commit
to ogrisel/scikit-learn
that referenced
this pull request
Jul 11, 2022
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Aug 4, 2022
glemaitre
pushed a commit
that referenced
this pull request
Aug 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Adress #21350
What does this implement/fix? Explain your changes.
Fixes the fetch_lfw_pairs to pass numpydoc validation
Any other comments?
This is my first open source contribution. Any guideance is really aprecciated . Thanks in advance!