MAINT validate parameters in DummyRegressor and DummyClassifier#23645
Merged
jeremiedbb merged 12 commits intoscikit-learn:mainfrom Jun 28, 2022
Merged
MAINT validate parameters in DummyRegressor and DummyClassifier#23645jeremiedbb merged 12 commits intoscikit-learn:mainfrom
jeremiedbb merged 12 commits intoscikit-learn:mainfrom
Conversation
glemaitre
approved these changes
Jun 27, 2022
Member
glemaitre
left a comment
There was a problem hiding this comment.
I pushed some changes since there is some collateral failures in successive halving tests.
Contributor
Author
Thanks. |
Member
|
@Nwanna-Joseph do not close the PR until someone else validates it and merges it. |
Contributor
Author
|
Mistakenly closed this. Reopening. |
Contributor
Author
Thanks. That was a mistake. Quick typing. |
jeremiedbb
approved these changes
Jun 28, 2022
Member
jeremiedbb
left a comment
There was a problem hiding this comment.
LGTM. Thanks @Nwanna-Joseph.
ogrisel
pushed a commit
to ogrisel/scikit-learn
that referenced
this pull request
Jul 11, 2022
…it-learn#23645) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> Co-authored-by: jeremiedbb <jeremiedbb@yahoo.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
See PR #23462
What does this implement/fix? Explain your changes.
Add validators for DummyClassifier and DummyRegressor. Towards #23462
Any other comments?