MAINT validate parameters in Birch#23593
Merged
jeremiedbb merged 6 commits intoscikit-learn:mainfrom Jun 28, 2022
kianelbo:birch-validation
Merged
MAINT validate parameters in Birch#23593jeremiedbb merged 6 commits intoscikit-learn:mainfrom kianelbo:birch-validation
jeremiedbb merged 6 commits intoscikit-learn:mainfrom
kianelbo:birch-validation
Conversation
_validate_params in Birch_validate_params in Birch
_validate_params in Birch_validate_params in Birch estimator
glemaitre
reviewed
Jun 13, 2022
_validate_params in Birch estimator
glemaitre
approved these changes
Jun 27, 2022
Member
glemaitre
left a comment
There was a problem hiding this comment.
LGTM. I think that we should let the test that checks for passing a non-ClusterMixin estimator since it is not covered by the common test specifically.
jeremiedbb
approved these changes
Jun 28, 2022
Member
jeremiedbb
left a comment
There was a problem hiding this comment.
LGTM. I just updated the docstring to reflect the fact that None is valid for n_clusters
Member
|
Thanks @kianelbo |
ogrisel
pushed a commit
to ogrisel/scikit-learn
that referenced
this pull request
Jul 11, 2022
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> Co-authored-by: jeremiedbb <jeremiedbb@yahoo.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
towards #23462
What does this implement/fix? Explain your changes.
Added
_parameter_constraintsfor Birch and removed the existing individual param checks.