Skip to content

MAINT validate parameter in RobustScaler#23588

Merged
glemaitre merged 8 commits intoscikit-learn:mainfrom
SangamSwadiK:validate_robust_scaler
Jun 27, 2022
Merged

MAINT validate parameter in RobustScaler#23588
glemaitre merged 8 commits intoscikit-learn:mainfrom
SangamSwadiK:validate_robust_scaler

Conversation

@SangamSwadiK
Copy link
Copy Markdown
Contributor

@SangamSwadiK SangamSwadiK commented Jun 11, 2022

Reference Issues/PRs

Issue: #23462 validating estimator params

What does this implement/fix? Explain your changes.

  • Implements parameter validation for robust scaler.
  • the fit method calls _validate_parameters as the first step to validate it.

Any other comments?

Please let me know if I missed something / did it incorrectly, ill fix it asap.

SangamSwadiK and others added 3 commits June 11, 2022 09:21
@SangamSwadiK
Remove Robust Scaler
74fcce3 
Remove Robust Scaler from to be validated
@SangamSwadiK
Add validation to Robust scaler
c2d0b35 
Add validation to robust scaler and check for validation in fit.
@SangamSwadiK
reformat for linting
ee9ba55
@jeremiedbb jeremiedbb added the Validation related to input validation label Jun 13, 2022
@jeremiedbb
Copy link
Copy Markdown
Member

jeremiedbb commented Jun 24, 2022

Thanks for the PR @SangamSwadiK. I directly pushed some changes to take into account recent improvements in the validation mechanism.

jeremiedbb
jeremiedbb approved these changes Jun 24, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SangamSwadiK SangamSwadiK changed the title Add parameter validation robust scaler [MRG]Add parameter validation robust scaler Jun 24, 2022
@glemaitre glemaitre changed the title [MRG]Add parameter validation robust scaler MAINT validate parameter in RobustScaler Jun 27, 2022
@glemaitre glemaitre self-requested a review June 27, 2022 07:48
glemaitre
glemaitre approved these changes Jun 27, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@glemaitre glemaitre merged commit 76ea15f into scikit-learn:main Jun 27, 2022
@glemaitre
Copy link
Copy Markdown
Member

glemaitre commented Jun 27, 2022

Thanks @SangamSwadiK Merging.

ogrisel pushed a commit to ogrisel/scikit-learn that referenced this pull request Jul 11, 2022
@SangamSwadiK @jeremiedbb @ogrisel
MAINT validate parameter in RobustScaler (scikit-learn#23588)
4f7ac6a 
Co-authored-by: Sangam Swadi K <sangamswadik@users.noreply.github.com>
Co-authored-by: jeremie du boisberranger <jeremiedbb@yahoo.fr>
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@glemaitre glemaitre glemaitre approved these changes

@jeremiedbb jeremiedbb jeremiedbb approved these changes

Assignees

No one assigned

Labels

module:preprocessing No Changelog Needed Validation related to input validation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SangamSwadiK @jeremiedbb @glemaitre