DOC Ensures that inplace_swap_column passes numpydoc validation#23476
Merged
thomasjpfan merged 2 commits intoscikit-learn:mainfrom May 27, 2022
Merged
DOC Ensures that inplace_swap_column passes numpydoc validation#23476thomasjpfan merged 2 commits intoscikit-learn:mainfrom
thomasjpfan merged 2 commits intoscikit-learn:mainfrom
Conversation
Contributor
Author
|
This is my first real contribution, if I have messed up anything please let me know, I would fix it. |
thomasjpfan
reviewed
May 27, 2022
Member
thomasjpfan
left a comment
There was a problem hiding this comment.
Thank you for the PR @harshit5674 !
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Contributor
Author
|
Thank you for the response ! |
thomasjpfan
approved these changes
May 27, 2022
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Aug 4, 2022
…it-learn#23476) Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com> Co-authored-by: harshit5674 <harshit@Harshits-MacBook-Air.local>
glemaitre
pushed a commit
that referenced
this pull request
Aug 5, 2022
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com> Co-authored-by: harshit5674 <harshit@Harshits-MacBook-Air.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Addresses #21350
What does this implement/fix? Explain your changes.
Fixed docstring to allow sklearn.utils.sparsefuncs.inplace_swap_column docstring to pass numpydoc validation.
Changed in accordance to SS05: Summary must start with infinitive verb, not third person.
Any other comments?