Merged
Conversation
… 21.3 and gives an error in pip 22
Member
Author
|
Looking at the pip changelog I am guessing that the relevant change is: |
glemaitre
reviewed
May 12, 2022
Member
glemaitre
left a comment
There was a problem hiding this comment.
I think that we can merge it as a hotfix for the moment.
I don't have a real fix for the new issue. I don't understand well enough the way pip and pyproject.toml work.
I would naively think that somehow, it should be fixed either in pip or the way the metadata from oldest-supported-numpy are rewired during the build version validation.
glemaitre
approved these changes
May 12, 2022
5 tasks
jeremiedbb
reviewed
May 12, 2022
jeremiedbb
reviewed
May 12, 2022
ogrisel
reviewed
May 12, 2022
Member
ogrisel
left a comment
There was a problem hiding this comment.
+1 for merge, with or without https://github.com/scikit-learn/scikit-learn/pull/23336/files#r871312452 assuming CI is still green.
ogrisel
approved these changes
May 12, 2022
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
May 19, 2022
glemaitre
pushed a commit
that referenced
this pull request
May 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--feature=in-tree-buildoption is ignored since pip 21.3 (see here) and gives an error in pip 22.See this build log
After doing the easy fixes, it seems that you need to pin pip to 22.0.4. The error is that
pip22.1 validates build dependencies in thepyproject.tomland so errors becauseoldest-supported-numpyis not installed: