DEP calibration_curve normalize parameter in calibration.py#23095
Merged
thomasjpfan merged 16 commits intoscikit-learn:mainfrom Apr 25, 2022
Merged
DEP calibration_curve normalize parameter in calibration.py#23095thomasjpfan merged 16 commits intoscikit-learn:mainfrom
thomasjpfan merged 16 commits intoscikit-learn:mainfrom
Conversation
glemaitre
reviewed
Apr 20, 2022
Member
glemaitre
left a comment
There was a problem hiding this comment.
We should add a new unit test that checks that we raise the proper FutureWarning if normalize != "deprecated".
In addition to checking the message, we can still make sure that normalize=True and normalize=False still lead to the expected results. We will remove this test in 1.3.
…ecate_calibration_curve_normalize
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
…ilke/scikit-learn into deprecate_calibration_curve_normalize
…ecate_calibration_curve_normalize
glemaitre
reviewed
Apr 22, 2022
…ecate_calibration_curve_normalize
…ecate_calibration_curve_normalize
thomasjpfan
reviewed
Apr 25, 2022
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
thomasjpfan
approved these changes
Apr 25, 2022
Member
thomasjpfan
left a comment
There was a problem hiding this comment.
One more doc comment, otherwise LGTM
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
jjerphan
pushed a commit
to jjerphan/scikit-learn
that referenced
this pull request
Apr 29, 2022
…earn#23095) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Close #22482
What does this implement/fix? Explain your changes.
Deprecates the normalize parameter of
calibration_curvein calibration.py in accordance with the guidelines.