ENH Adds FeatureHasher support to pypy#23023
Merged
lorentzenchr merged 10 commits intoscikit-learn:mainfrom Apr 8, 2022
Merged
ENH Adds FeatureHasher support to pypy#23023lorentzenchr merged 10 commits intoscikit-learn:mainfrom
lorentzenchr merged 10 commits intoscikit-learn:mainfrom
Conversation
jeremiedbb
reviewed
Apr 4, 2022
| return ITYPECODE | ||
|
|
||
|
|
||
| cdef class StdVectorSentinelInt32(StdVectorSentinel): |
Member
There was a problem hiding this comment.
This is starting to look like tempita material 😄
Member
|
THe pypy run did not get it through :( |
Member
Author
|
Currently, PyPy already timeouts on main. I increased the timeout duration for PyPy in this PR so the test has a chance to complete. |
Member
|
A green pypy CI would be nice. After that we should revert c008f80 (don't we?) and then merge. |
Member
jjerphan
pushed a commit
to jjerphan/scikit-learn
that referenced
this pull request
Apr 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #11540
What does this implement/fix? Explain your changes.
This PR enables FeatureHasher to work on pypy by using c++ vectors in the transform call. Running this benchmark:
Benchmark
Here are my results:
Any other comments?
Int32 and Int64 were added to the vector sentinel to support the hasher.