DOC Ensures that laplacian_kernel passes numpydoc validation#23005
Merged
thomasjpfan merged 5 commits intoscikit-learn:mainfrom Apr 4, 2022
Merged
DOC Ensures that laplacian_kernel passes numpydoc validation#23005thomasjpfan merged 5 commits intoscikit-learn:mainfrom
thomasjpfan merged 5 commits intoscikit-learn:mainfrom
Conversation
jeremiedbb
reviewed
Mar 31, 2022
Member
|
Thanks for the PR @gustavo-ren. I made some suggestions. |
Adding sugestiong by jeremiedbb Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
Adding sugestiong by jeremiedbb Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
gustavo-ren
commented
Apr 1, 2022
Contributor
Author
gustavo-ren
left a comment
There was a problem hiding this comment.
Great suggestions, thank you!
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Apr 6, 2022
…learn#23005) * laplacian_kernel docstring correction on issue scikit-learn#21350 * Update sklearn/metrics/pairwise.py Adding sugestiong by jeremiedbb Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com> * Update sklearn/metrics/pairwise.py Adding sugestiong by jeremiedbb Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com> * Update sklearn/metrics/pairwise.py Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com> Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
jjerphan
pushed a commit
to jjerphan/scikit-learn
that referenced
this pull request
Apr 29, 2022
…learn#23005) * laplacian_kernel docstring correction on issue scikit-learn#21350 * Update sklearn/metrics/pairwise.py Adding sugestiong by jeremiedbb Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com> * Update sklearn/metrics/pairwise.py Adding sugestiong by jeremiedbb Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com> * Update sklearn/metrics/pairwise.py Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com> Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Addresses #21350