Skip to content

DOC adds two dots from datasets._base.load_sample_image#22805

Merged
jeremiedbb merged 4 commits intoscikit-learn:mainfrom
victoirelouis:doc_base
Mar 21, 2022
Merged

DOC adds two dots from datasets._base.load_sample_image#22805
jeremiedbb merged 4 commits intoscikit-learn:mainfrom
victoirelouis:doc_base

Conversation

@victoirelouis
Copy link
Copy Markdown
Contributor

@victoirelouis victoirelouis commented Mar 12, 2022

Reference Issues/PRs

toward #21350 #pariswimlds

What does this implement/fix? Explain your changes.

Add two dots to docstrings.

Any other comments?

Copy link
Copy Markdown
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

We still need to remove:

"sklearn.datasets._base.load_sample_image",

to make sure our tests run on load_sample_image.

Copy link
Copy Markdown
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeremiedbb jeremiedbb merged commit eea5a10 into scikit-learn:main Mar 21, 2022
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Apr 6, 2022
…#22805)

Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants