Skip to content

DOC Ensures that preprocessing._data.power_transform passes numpydoc validation#22802

Merged
jeremiedbb merged 3 commits intoscikit-learn:mainfrom
ducanne:fix_doc_preprocessing_data_power_transform
Mar 21, 2022
Merged

DOC Ensures that preprocessing._data.power_transform passes numpydoc validation#22802
jeremiedbb merged 3 commits intoscikit-learn:mainfrom
ducanne:fix_doc_preprocessing_data_power_transform

Conversation

@ducanne
Copy link
Copy Markdown
Contributor

@ducanne ducanne commented Mar 12, 2022

Reference Issues/PRs

Addresses #21350

What does this implement/fix? Explain your changes.

2 formatting changes (one double line break to remove, and order of sections changed - "Examples" section moved to the end) + initial summary of the function must be one line maximum (I just added one line at the beginning, very short summary of the what the function does).

Any other comments?

#pariswimlds

Copy link
Copy Markdown
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. The CI has a failure in the linter step. Instructions to fix it in the second comment below:

@jeremiedbb jeremiedbb added No Changelog Needed Quick Review For PRs that are quick to review labels Mar 18, 2022
Copy link
Copy Markdown
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ducanne

@jeremiedbb jeremiedbb merged commit 5cccdef into scikit-learn:main Mar 21, 2022
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Apr 6, 2022
…validation (scikit-learn#22802)

Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants