DOC Ensures that sklearn.preprocessing._data.binarize passes numpydoc validation#22801
Merged
GaelVaroquaux merged 1 commit intoscikit-learn:mainfrom Mar 12, 2022
Merged
Conversation
adrinjalali
reviewed
Mar 12, 2022
.gitignore
Outdated
| build | ||
| sklearn/datasets/__config__.py | ||
| sklearn/**/*.html | ||
| .env |
Member
There was a problem hiding this comment.
I'm happy with this change, but it needs its own PR
Member
There was a problem hiding this comment.
Indeed, two PRs got mixed. We fixed
| ] | ||
| assert_array_equal(expected_names, names) | ||
|
|
||
| # def test_rf_regressor_prediction_range(): |
Member
There was a problem hiding this comment.
I think you didn't mean to comment these tests in this PR
0d60bf2 to
f7ebeee
Compare
GaelVaroquaux
approved these changes
Mar 12, 2022
Member
GaelVaroquaux
left a comment
There was a problem hiding this comment.
LGTM.
As these changes are documentation only, I will merge once tests are green.
GaelVaroquaux
approved these changes
Mar 12, 2022
Member
GaelVaroquaux
left a comment
There was a problem hiding this comment.
LGTM.
As these changes are documentation only, I will merge once tests are green.
Contributor
|
Adding the #pariswimlds hashtag :-) |
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Apr 6, 2022
Co-authored-by: Magali Morin <magali.morin@student-cs.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Addresses #21350
What does this implement/fix? Explain your changes.
Any other comments?