Skip to content

DOC fix the docstring of sklearn.datasets._samples_generator.make_biclusters#22790

Merged
ogrisel merged 2 commits intoscikit-learn:mainfrom
cdrig:21350-datasets-_generate_samples-make_biclusters
Mar 13, 2022
Merged

DOC fix the docstring of sklearn.datasets._samples_generator.make_biclusters#22790
ogrisel merged 2 commits intoscikit-learn:mainfrom
cdrig:21350-datasets-_generate_samples-make_biclusters

Conversation

@cdrig
Copy link
Copy Markdown
Contributor

@cdrig cdrig commented Mar 12, 2022

Reference Issues/PRs

#21350

What does this implement/fix? Explain your changes.

Fix the doctrings:

  • Reference part after the See Also part
  • Add the description of the function pointed in See Also
  • The general description's length is one line

Any other comments?

#WiMLDS

@MarieSacksick
Copy link
Copy Markdown
Contributor

MarieSacksick commented Mar 12, 2022

PR done in the context of #pariswimlds

@ogrisel ogrisel changed the title fix docstring make_biclusters DOC fix the docstring of sklearn.datasets._samples_generator.make_biclusters Mar 13, 2022
Copy link
Copy Markdown
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for the PR. I just edited the title to include the full function name to make it easier to automatically update the list of functions in #21350.

@ogrisel ogrisel merged commit 9b1978d into scikit-learn:main Mar 13, 2022
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants