Skip to content

#21350 - fix make_multilabel_classification docstring#22782

Merged
GaelVaroquaux merged 2 commits intoscikit-learn:mainfrom
mathieu-sabatier:21350-make_multilabel_classification
Mar 13, 2022
Merged

#21350 - fix make_multilabel_classification docstring#22782
GaelVaroquaux merged 2 commits intoscikit-learn:mainfrom
mathieu-sabatier:21350-make_multilabel_classification

Conversation

@mathieu-sabatier
Copy link
Copy Markdown
Contributor

Reference Issues/PRs

Part of the issue #21350.

What does this implement/fix? Explain your changes.

Correct two typos of the doctring to pass numpydoc requirements for multilabel_classification sample generator.

Any other comments?

Test can be run thanks to:

pytest sklearn/tests/test_docstrings.py -k sklearn.datasets._samples_generator.make_multilabel_classification -v

Thanks #WiMLDS

Copy link
Copy Markdown
Member

@GaelVaroquaux GaelVaroquaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

As these changes are documentation only, I will merge once tests are green (I'll fix the conflicts).

@GaelVaroquaux
Copy link
Copy Markdown
Member

I resolved the conflict

@GaelVaroquaux GaelVaroquaux merged commit 45d70df into scikit-learn:main Mar 13, 2022
@chagaz
Copy link
Copy Markdown
Contributor

chagaz commented Mar 14, 2022

Adding the #pariswimlds hashtag :-)

glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Apr 6, 2022
…n doctring (scikit-learn#22782)

Co-authored-by: Gael Varoquaux <gael.varoquaux@normalesup.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants