MAINT Bump versions to match oldest-supported-numpy#22674
Merged
ogrisel merged 4 commits intoscikit-learn:mainfrom Mar 4, 2022
Merged
MAINT Bump versions to match oldest-supported-numpy#22674ogrisel merged 4 commits intoscikit-learn:mainfrom
ogrisel merged 4 commits intoscikit-learn:mainfrom
Conversation
jjerphan
approved these changes
Mar 4, 2022
Member
|
I think it's worth checking what backward compat tool is not necessary anymore when bumping the min version of the dependencies. Otherwise we end up keeping dead code in the code base for a long time. I think this bump only allows to remove |
jeremiedbb
reviewed
Mar 4, 2022
Member
|
I did a bunch of quick git greps and could not find other occurrences of #22674 (comment). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Follow up to #22617
What does this implement/fix? Explain your changes.
This PR bumps the NumPy minimal dependency to match the ones seen in oldest-supported-numpy
CC @ogrisel