MNT Drops Python 3.7 in CI, wheel building, and docs#22617
Merged
jjerphan merged 15 commits intoscikit-learn:mainfrom Feb 28, 2022
Merged
MNT Drops Python 3.7 in CI, wheel building, and docs#22617jjerphan merged 15 commits intoscikit-learn:mainfrom
jjerphan merged 15 commits intoscikit-learn:mainfrom
Conversation
Member
Author
|
PyPy3.8 is not fully ready yet: conda-forge/conda-forge-pinning-feedstock#2089 For now, I am keeping 3.7 on just for PyPy test to run and build. |
Member
Author
|
Looks like everything works now. The pypy build failure is the same on |
Member
Author
|
The pypy error fix is at #22619 |
Member
Author
|
Thanks for updating the pyproject.toml. Looks like the wheel builds work. The random window build errors are expected: #22310 |
Member
|
@adrinjalali @lesteve merge? |
This was referenced Feb 26, 2022
jjerphan
approved these changes
Feb 28, 2022
Member
jjerphan
left a comment
There was a problem hiding this comment.
LGTM after addressing remaining comments, thank you @thomasjpfan.
thomasjpfan
added a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Mar 1, 2022
) * MNT Drops Python 3.7 * MNT Bump NumPy and SciPy * FIX Fix build * FIX Bump versions improved * DOC Fixes numpy version [pypy] * BLD [pypy] [icc-build] * Update docs * MAINT use scipy.optimize.LinearConstraint in test * MAINT scipy 1.1.0 related code clean-up * scipy>=1.3.2 in pyproject.toml's build deps * [cd build] * DOC Adds comment about pypy * MAINT remove _astype_copy_false * FIX Update check for python version in setup.py Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
29 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Related to #21460
Related to #22614
What does this implement/fix? Explain your changes.
This PR bumps the Python version in the CI and docs.