DOC Ensures that load_linnerud passes numpydoc validation#22484
Merged
thomasjpfan merged 4 commits intoscikit-learn:mainfrom Feb 27, 2022
Merged
DOC Ensures that load_linnerud passes numpydoc validation#22484thomasjpfan merged 4 commits intoscikit-learn:mainfrom
thomasjpfan merged 4 commits intoscikit-learn:mainfrom
Conversation
glemaitre
reviewed
Feb 16, 2022
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Contributor
Author
|
@glemaitre this PR is still open. Hopefully you haven't forgotten about it 😄 |
thomasjpfan
reviewed
Feb 26, 2022
Member
thomasjpfan
left a comment
There was a problem hiding this comment.
Thanks for the PR @DennisOsei !
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Contributor
Author
|
Thanks @thomasjpfan, commited the suggested changes. |
thomasjpfan
approved these changes
Feb 26, 2022
Member
thomasjpfan
left a comment
There was a problem hiding this comment.
Minor comment otherwise LGTM
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Contributor
Author
|
@thomasjpfan updated. |
thomasjpfan
added a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Mar 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Addresses #21350
What does this implement/fix? Explain your changes.
Any other comments?