Skip to content

DOC Ensures that make_scorer passes numpydoc validation#22367

Merged
thomasjpfan merged 3 commits intoscikit-learn:mainfrom
jmloyola:fix_numpydoc_make_scorer
Feb 9, 2022
Merged

DOC Ensures that make_scorer passes numpydoc validation#22367
thomasjpfan merged 3 commits intoscikit-learn:mainfrom
jmloyola:fix_numpydoc_make_scorer

Conversation

@jmloyola
Copy link
Copy Markdown
Member

@jmloyola jmloyola commented Feb 3, 2022

Reference Issues/PRs

Addresses #21350.

What does this implement/fix? Explain your changes.

This PR:

  • Removes make_scorer from FUNCTION_DOCSTRING_IGNORE_LIST.
  • Fixes numpydocs from make_scorer.
  • Fixes broken links for ~sklearn.metrics.adjusted_rand_score and ~sklearn.metrics.average_precision_score

Copy link
Copy Markdown
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @jmloyola !

LGTM

@thomasjpfan thomasjpfan merged commit 5d167a5 into scikit-learn:main Feb 9, 2022
@jmloyola jmloyola deleted the fix_numpydoc_make_scorer branch February 9, 2022 15:23
ilivans pushed a commit to ilivans/scikit-learn that referenced this pull request Feb 10, 2022
thomasjpfan pushed a commit to thomasjpfan/scikit-learn that referenced this pull request Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants