Skip to content

DOC Ensures that manhattan_distances passes numpydoc validation#22139

Merged
thomasjpfan merged 6 commits intoscikit-learn:mainfrom
Micky774:numpydoc_manhatten_distances
Jan 10, 2022
Merged

DOC Ensures that manhattan_distances passes numpydoc validation#22139
thomasjpfan merged 6 commits intoscikit-learn:mainfrom
Micky774:numpydoc_manhatten_distances

Conversation

@Micky774
Copy link
Copy Markdown
Contributor

@Micky774 Micky774 commented Jan 7, 2022

Reference Issues/PRs

Addresses #21350

What does this implement/fix? Explain your changes.

Brings the function sklearn.metrics.pairwise.manhattan_distances into numpydoc compliance

Any other comments?

N/A

Copy link
Copy Markdown
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
@thomasjpfan
Copy link
Copy Markdown
Member

There is a merge conflict now, likely due to merging #22140.

Copy link
Copy Markdown
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan changed the title DOC Ensures that sklearn.metrics.pairwise.manhattan_distances passes numpydoc validation DOC Ensures that manhattan_distances passes numpydoc validation Jan 10, 2022
@thomasjpfan thomasjpfan merged commit ff09c8a into scikit-learn:main Jan 10, 2022
@Micky774 Micky774 deleted the numpydoc_manhatten_distances branch February 22, 2022 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants