Skip to content

DOC Ensures that nan_euclidean_distances passes numpydoc#22140

Merged
thomasjpfan merged 4 commits intoscikit-learn:mainfrom
Micky774:numpydoc_nan_euclidean_distances
Jan 10, 2022
Merged

DOC Ensures that nan_euclidean_distances passes numpydoc#22140
thomasjpfan merged 4 commits intoscikit-learn:mainfrom
Micky774:numpydoc_nan_euclidean_distances

Conversation

@Micky774
Copy link
Copy Markdown
Contributor

@Micky774 Micky774 commented Jan 7, 2022

Reference Issues/PRs

Addresses #21350

What does this implement/fix? Explain your changes.

Brings sklearn.metrics.pairwise.nan_euclidean_distances documentation into numpydoc compliance

Any other comments?

N/A

Copy link
Copy Markdown
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @Micky774 !

Copy link
Copy Markdown
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

Edit: Linting errors can be found here

Copy link
Copy Markdown
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan changed the title DOC Ensures that sklearn.metrics.pairwise.nan_euclidean_distances passes numpydoc validation DOC Ensures that nan_euclidean_distances passes numpydoc Jan 10, 2022
@thomasjpfan thomasjpfan merged commit a990fc8 into scikit-learn:main Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants