Skip to content

DOC Ensures that silhouette_samples passes numpydoc#21851

Merged
thomasjpfan merged 3 commits intoscikit-learn:mainfrom
mlant:mlant_21350_2
Dec 20, 2021
Merged

DOC Ensures that silhouette_samples passes numpydoc#21851
thomasjpfan merged 3 commits intoscikit-learn:mainfrom
mlant:mlant_21350_2

Conversation

@mlant
Copy link
Copy Markdown
Contributor

@mlant mlant commented Dec 1, 2021

DOC Ensures that sklearn.metrics.cluster._unsupervised.silhouette_samples
#21350

What does this implement/fix? Explain your changes.

fix tipos

Any other comments?

@glemaitre
Copy link
Copy Markdown
Member

LGTM. Could we ou solve the conflicts then we could merge.

Copy link
Copy Markdown
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @mlant !

LGTM

Edit: Looking into CI error.

@thomasjpfan
Copy link
Copy Markdown
Member

Merging as the issue is on main most likely related to setuptools==60.0.0.

@thomasjpfan thomasjpfan changed the title DOC Ensures that sklearn.metrics.cluster._unsupervised.silhouette_sam… DOC Ensures that silhouette_samples passes numpydoc Dec 20, 2021
@thomasjpfan thomasjpfan merged commit 913c866 into scikit-learn:main Dec 20, 2021
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Dec 24, 2021
glemaitre pushed a commit that referenced this pull request Dec 25, 2021
Co-authored-by: mlant <marie.lanternier@free.fr>
venkyyuvy pushed a commit to venkyyuvy/scikit-learn that referenced this pull request Jan 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants