Skip to content

Accelerate plot_image_denoising.py#21799

Merged
jjerphan merged 3 commits intoscikit-learn:mainfrom
nastegiano:accelerate_example_plot_image_denoising
Dec 6, 2021
Merged

Accelerate plot_image_denoising.py#21799
jjerphan merged 3 commits intoscikit-learn:mainfrom
nastegiano:accelerate_example_plot_image_denoising

Conversation

@nastegiano
Copy link
Copy Markdown
Contributor

@nastegiano nastegiano commented Nov 26, 2021

Reference Issues/PRs

#21598

What does this implement/fix? Explain your changes.

Accelerate computation time for the example plot_image_denoising.

I changed :

  • in the function MiniBatchDictionaryLearning : n_component which has decrease from 100 to 50 and n_iter which has decrease from 500 to 250
  • for the lars function : I choosed 4 instead of 5 to accelerate it

These are the results that I obtained :

contrib_final

Any other comments?

@adrinjalali adrinjalali changed the title Accelerate example plot image denoising Accelerate plot_image_denoising.py Nov 29, 2021
@adrinjalali
Copy link
Copy Markdown
Member

Please apply black to your code, seems like it likes the spaces you've removed.

@adrinjalali adrinjalali mentioned this pull request Nov 29, 2021
41 tasks
@nastegiano
Copy link
Copy Markdown
Contributor Author

@adrinjalali I applied black on my .py like you said and all checks have passed

@adrinjalali
Copy link
Copy Markdown
Member

@jjerphan this should be a quick one :)

@jjerphan jjerphan merged commit eed85ce into scikit-learn:main Dec 6, 2021
@jjerphan
Copy link
Copy Markdown
Member

jjerphan commented Dec 6, 2021

Thanks @nastegiano for your contribution, thanks @adrinjalali for the mention.

glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Dec 24, 2021
glemaitre pushed a commit that referenced this pull request Dec 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants