DOC Accelerate plot_missing_values.py example#21792
Merged
glemaitre merged 4 commits intoscikit-learn:mainfrom May 3, 2022
Merged
DOC Accelerate plot_missing_values.py example#21792glemaitre merged 4 commits intoscikit-learn:mainfrom
glemaitre merged 4 commits intoscikit-learn:mainfrom
Conversation
41 tasks
Member
|
I think that it will be good enough. We should revisit anyway this example as part of #21967 |
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
May 19, 2022
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
glemaitre
added a commit
that referenced
this pull request
May 19, 2022
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
References #21598
Accelerates
../examples/impute/plot_missing_values.pyWhat does this implement/fix? Explain your changes.
The IterativeImputer was the main bottleneck which took ~13s. Decreased
n_nearest_featuresandmax_iterswithout any meaningful drop in performance. Other changes include decreasing the size of both the datasets, etc. to get it down to <15s.Time taken decreased from ~28s to ~14s on my machine.
Output before the changes:
And after the changes:
Any other comments?