MNT speed up plot_nca_classification.py#21771
Merged
ogrisel merged 2 commits intoscikit-learn:mainfrom Nov 26, 2021
Merged
Conversation
41 tasks
glemaitre
reviewed
Nov 25, 2021
Member
|
Thanks! |
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Nov 29, 2021
* accelerate plot_nca_classification.py * change step size to 0.05
samronsin
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Nov 30, 2021
* accelerate plot_nca_classification.py * change step size to 0.05
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Dec 24, 2021
* accelerate plot_nca_classification.py * change step size to 0.05
glemaitre
pushed a commit
that referenced
this pull request
Dec 25, 2021
* accelerate plot_nca_classification.py * change step size to 0.05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Almost 90 percent of runtime is related directly to step size and changing it from 0.01 to 0.015 improves the runtime by 50 percent.
I'm not sure it even deserves a PR but based on my observation the difference in quality of boundaries is negligible.
with 0.01 step size: 25.3 second runtime
with 0.015 step size: 10.6 second runtime
Reference Issues/PRs
#21598
What does this implement/fix? Explain your changes.
Any other comments?