ENH Impoving execution speed of plot_pca_vs_fa_model_selection.py by …#21671
Merged
agramfort merged 8 commits intoscikit-learn:mainfrom Nov 20, 2021
Iglesys347:increase_speed_plot_pca_vs_fa_model_selection
Merged
ENH Impoving execution speed of plot_pca_vs_fa_model_selection.py by …#21671agramfort merged 8 commits intoscikit-learn:mainfrom Iglesys347:increase_speed_plot_pca_vs_fa_model_selection
agramfort merged 8 commits intoscikit-learn:mainfrom
Iglesys347:increase_speed_plot_pca_vs_fa_model_selection
Conversation
…dividing by 2 parameters n_samples, n_features, rank
ogrisel
approved these changes
Nov 15, 2021
Member
There was a problem hiding this comment.
LGTM, thanks for the speed improvement. The conclusions in the text still hold with this dataset.
In the text, I believe that the sentence "Under appropriate circumstances the low rank models are more likely than shrinkage models." is wrong. I should rather be written: "Under appropriate circumstances (choice of the number of components), the held-out data is more likely for low rank models than for shrinkage models.".
This is because the likelihood is a property of the data for a given model rather than a property of a model for given data. Maybe @agramfort or someone else can double check the suggested phrasing above.
41 tasks
Member
|
@ogrisel I agree with the phrasing you suggest |
Contributor
Author
|
@ogrisel @agramfort Should I change this myself in this PR ? |
Member
|
yes go for it!
… |
Retrieve latest chagement
…dividing by 2 parameters n_samples, n_features, rank
…b.com:Iglesys347/scikit-learn into increase_speed_plot_pca_vs_fa_model_selection
Get letest repo updates
…se_speed_plot_pca_vs_fa_model_selection
Contributor
Author
|
@ogrisel @agramfort I applied your suggestions and the pipeline seems good. |
agramfort
approved these changes
Nov 20, 2021
Member
|
Thx @Iglesys347 |
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Nov 22, 2021
scikit-learn#21671) * ENH Impoving execution speed of plot_pca_vs_fa_model_selection.py by dividing by 2 parameters n_samples, n_features, rank * Update docstring according to @ogrisel 's comment * ENH Impoving execution speed of plot_pca_vs_fa_model_selection.py by dividing by 2 parameters n_samples, n_features, rank * Update docstring according to @ogrisel 's comment
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Nov 29, 2021
scikit-learn#21671) * ENH Impoving execution speed of plot_pca_vs_fa_model_selection.py by dividing by 2 parameters n_samples, n_features, rank * Update docstring according to @ogrisel 's comment * ENH Impoving execution speed of plot_pca_vs_fa_model_selection.py by dividing by 2 parameters n_samples, n_features, rank * Update docstring according to @ogrisel 's comment
samronsin
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Nov 30, 2021
scikit-learn#21671) * ENH Impoving execution speed of plot_pca_vs_fa_model_selection.py by dividing by 2 parameters n_samples, n_features, rank * Update docstring according to @ogrisel 's comment * ENH Impoving execution speed of plot_pca_vs_fa_model_selection.py by dividing by 2 parameters n_samples, n_features, rank * Update docstring according to @ogrisel 's comment
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Dec 24, 2021
scikit-learn#21671) * ENH Impoving execution speed of plot_pca_vs_fa_model_selection.py by dividing by 2 parameters n_samples, n_features, rank * Update docstring according to @ogrisel 's comment * ENH Impoving execution speed of plot_pca_vs_fa_model_selection.py by dividing by 2 parameters n_samples, n_features, rank * Update docstring according to @ogrisel 's comment
glemaitre
pushed a commit
that referenced
this pull request
Dec 25, 2021
#21671) * ENH Impoving execution speed of plot_pca_vs_fa_model_selection.py by dividing by 2 parameters n_samples, n_features, rank * Update docstring according to @ogrisel 's comment * ENH Impoving execution speed of plot_pca_vs_fa_model_selection.py by dividing by 2 parameters n_samples, n_features, rank * Update docstring according to @ogrisel 's comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…dividing by 2 parameters n_samples, n_features, rank
Reference Issues/PRs
References #21598
What does this implement/fix? Explain your changes.
Increase the execution speed of
scikit-learn/examples/decomposition/plot_pca_vs_fa_model_selection.pyby reducing some parameters.Time taken before modification (time taken measured with the
timeunix command):real 1m49,943s
user 4m6,328s
sys 2m52,386s
Time taken after modification:
real 0m14,672s
user 0m23,755s
sys 0m19,608s
Graphs before modification:
Graphs after modification:
Any other comments?