[MRG] Speed up plot_discretization_classification.py#21661
Merged
TomDLT merged 7 commits intoscikit-learn:mainfrom Nov 16, 2021
Merged
[MRG] Speed up plot_discretization_classification.py#21661TomDLT merged 7 commits intoscikit-learn:mainfrom
TomDLT merged 7 commits intoscikit-learn:mainfrom
Conversation
41 tasks
adrinjalali
reviewed
Nov 15, 2021
Member
adrinjalali
left a comment
There was a problem hiding this comment.
Overall nice improvement, I wouldn't have changed c_, but I also don't mind the change.
And nice catch on the StandardScaler issue.
adrinjalali
reviewed
Nov 15, 2021
Member
|
you need to apply Also, please merge with the latest |
Contributor
Author
|
I forgot to merge the latest |
adrinjalali
approved these changes
Nov 16, 2021
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Nov 22, 2021
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Nov 29, 2021
samronsin
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Nov 30, 2021
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Dec 24, 2021
glemaitre
pushed a commit
that referenced
this pull request
Dec 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
#21598
What does this implement/fix? Explain your changes.
I reduce the parameter search space.
Another issue: the original code standardizes the entire dataset, which may cause data leakage. I moved the
StandardScalerinto the pipelines.before: 28s
after: 6s
Any other comments?