ENH Improve speed plot_adaboost_multiclass.py#21651
Conversation
adrinjalali
left a comment
There was a problem hiding this comment.
Is this reproducing the original chart now (i.e. Figure 1 of Zhu et al)? Please check what the text refers to, and what the original chart is supposed to be like, and adapt the text accordingly if necessary.
| n_samples=13000, n_features=10, n_classes=3, random_state=1 | ||
| ) | ||
|
|
||
| n_split = 3000 | ||
| n_split = 2000 |
There was a problem hiding this comment.
this is not reducing the number of splits, it's the size of the training set. You can instead make the size of the training set also smaller, and use train_test_split to get like 50% for training.
There was a problem hiding this comment.
How does this then have an impact on the execution time if it's just the relation train to test?
There was a problem hiding this comment.
I changed it back from 2000 to the original 3000. Even with only the n_estimators parameters changed, time reduction is from 16 sec to 7 sec
|
Is it still reproducing the aforementioned figure from the original article? In terms of required input for instance. |
|
@adrinjalali Yes, still looking extremely similar |
|
Thanks @sveneschlbeck ! |
#21598 @TomDLT @adrinjalali
Tuned down the estimator number a bit, also decreased the number of splits.
