MNT speed up example plot_svm_scale_c.py#21625
Merged
Conversation
Member
|
Did you try 50 splits? Also, you could reset the CI by sending an empty commit by |
Author
|
@adrinjalali Will check. Back with the new results soon |
Author
|
@adrinjalali Good call, it did indeed still perform pretty close to the original but time is down 5 sec more.. |
41 tasks
Member
|
This looks good, what do the times look like now? |
Author
|
@adrinjalali The pictures directly above are related to that improvement. The results were:
|
adrinjalali
approved these changes
Nov 12, 2021
Member
|
@glemaitre maybe? |
glemaitre
approved these changes
Nov 24, 2021
Member
glemaitre
left a comment
There was a problem hiding this comment.
Thanks @sveneschlbeck LGTM Merging
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Nov 29, 2021
samronsin
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Nov 30, 2021
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Dec 24, 2021
glemaitre
pushed a commit
that referenced
this pull request
Dec 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#21598 @adrinjalali @sply88
Increased speed by decreasing the number of splits from 250 to 100 while maintaining more or less the same result (decreasing number of features is contra-productive because it does not save time but makes the model significantly worse).
