Increase execution speed of plot_cluster_comparison.py#21624
Merged
adrinjalali merged 7 commits intoscikit-learn:mainfrom Mar 10, 2022
Iglesys347:increse_execution_speed_plot_cluster_comparison
Merged
Increase execution speed of plot_cluster_comparison.py#21624adrinjalali merged 7 commits intoscikit-learn:mainfrom Iglesys347:increse_execution_speed_plot_cluster_comparison
adrinjalali merged 7 commits intoscikit-learn:mainfrom
Iglesys347:increse_execution_speed_plot_cluster_comparison
Conversation
41 tasks
Member
|
The optics results don't look very good now, could you please play with its parameters so that you get a similar result as before? |
Contributor
Author
|
Yes, I agree, I'm working on it. |
Retrieve last changes
… working on the other datasets
Contributor
Author
|
@adrinjalali I played with the parameters and the results looks better to me, what do you think ? |
Member
|
@Iglesys347 would you mind merging with the latest |
Contributor
Author
|
@adrinjalali I merged the latest main and the checks fails ; but they did not fail before and I didn't change anything in the code. |
Member
|
The CI error is unrelated to your change and is being addressed in #22381 |
adrinjalali
approved these changes
Feb 8, 2022
Contributor
Author
|
Hello @adrinjalali I merged the latest changes from |
Member
|
Yep, this is perfect, thank you @Iglesys347 |
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Apr 6, 2022
…arn#21624) * Reduced n_samples to increse speed * ENH imporved visuals of Optic method for the first two dataset, still working on the other datasets * ENH improved visuals for Optic method by tuning parameters * Linting with black
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
References #21598
What does this implement/fix? Explain your changes.
Reduced the number of parameters (divided by 3) in order to increase the execution speed.
Here is the graphs with the base method (1500 parameters) :
And here the ones with the new method (500 parameters):
Finally the graphs with 500 parameters and tunned parameters
We cannot reduce more the number of parameters otherwise we would not be able to see the scalability.
Any other comments?