MNT accelerate plot_gradient_boosting_early_stopping.py example#21609
Merged
thomasjpfan merged 5 commits intoscikit-learn:mainfrom Nov 27, 2021
Merged
Conversation
41 tasks
Member
|
Here too, please paste both before and after plots, to make the reviews faster and more fluent. |
Contributor
Author
|
Sure. After plots are in original description on top. Before plots look like this: |
Member
|
Could you try replacing the digits dataset with a synthetic dataset ( |
Contributor
Author
|
Done. Have also reduces sample size for Hastie data a bit more. Time is down to 4s. Output for last commit looks like this: |
adrinjalali
approved these changes
Nov 23, 2021
Member
adrinjalali
left a comment
There was a problem hiding this comment.
LGTM, thanks @sply88.
@glemaitre WDYT? It makes a 48s example a 2s example.
thomasjpfan
reviewed
Nov 26, 2021
Member
thomasjpfan
left a comment
There was a problem hiding this comment.
Thank you for the PR @sply88 !
Makes example results deterministic. Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
…ng_early_stopping.py
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Nov 29, 2021
…it-learn#21609) Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
samronsin
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Nov 30, 2021
…it-learn#21609) Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Dec 24, 2021
…it-learn#21609) Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
glemaitre
pushed a commit
that referenced
this pull request
Dec 25, 2021
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Speeds up ../examples/ensemble/plot_gradient_boosting_early_stopping.py (Issue #21598) by
make_hastie_10_2n_estimatorsto 200On my laptop example now takes sub 11 seconds (previously plus 50).
Main points (almost same accuracy and significant reduction of training time) are still very obvious in the plots:
