MNT pin PyWavelet in doc-min builds#21607
Conversation
|
OK. So the thing that is fishy here is:
@jorisvandenbossche mentioned that it could be something linked with the latest release of setuptools. I will downgrade to investigate this. |
|
Actually, it might only be some |
|
I opened pypa/pip#10651 to report the misleading log given by |
|
pinging @adrinjalali @thomasjpfan |
| wget https://github.com/conda-forge/miniforge/releases/latest/download/Mambaforge-Linux-x86_64.sh \ | ||
| -O miniconda.sh |
There was a problem hiding this comment.
O_o do we want to switch to mamba? why not miniforge?
There was a problem hiding this comment.
It was for debugging reasons first. Then, I assume that mamba will be faster than conda to resolve the dependencies required here.
| # NumPy version required. If PyWavelets 1.2+ is installed, it would require | ||
| # NumPy 1.17+ that trigger a bug with Pandas 0.25: | ||
| # https://github.com/numpy/numpy/issues/18355#issuecomment-774610226 | ||
| pip install PyWavelets==1.1.1 |
There was a problem hiding this comment.
we need a comment here, or in our min dependency file, which would remind us to remove this once we bump our min numpy requirement.
adrinjalali
left a comment
There was a problem hiding this comment.
LGTM, and the circleCI passes.
thomasjpfan
left a comment
There was a problem hiding this comment.
LGTM to unblock other PRs
For the future, I would prefer to remove the skimage dependency from our examples and docs.
PyWavelets1.2.0 requiresnumpy>= 1.17 that is not has a known bug withpandas<= 1.2.Pinning the version of
PyWaveletswould be enough here.