DOC Ensures that function passes numpydoc validation: has_fit_parameter#21590
Merged
jjerphan merged 3 commits intoscikit-learn:mainfrom Nov 15, 2021
Merged
DOC Ensures that function passes numpydoc validation: has_fit_parameter#21590jjerphan merged 3 commits intoscikit-learn:mainfrom
jjerphan merged 3 commits intoscikit-learn:mainfrom
Conversation
glemaitre
approved these changes
Nov 7, 2021
maint_tools/test_docstrings.py
Outdated
| "sklearn.utils.validation.check_random_state", | ||
| "sklearn.utils.validation.column_or_1d", | ||
| "sklearn.utils.validation.has_fit_parameter", | ||
| # "sklearn.utils.validation.has_fit_parameter", |
Member
There was a problem hiding this comment.
You can remove this line then.
jjerphan
approved these changes
Nov 15, 2021
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Nov 22, 2021
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Nov 29, 2021
samronsin
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Nov 30, 2021
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Dec 24, 2021
glemaitre
pushed a commit
that referenced
this pull request
Dec 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
References #21350.
Closes #21471.
What does this implement/fix? Explain your changes.
Updates docstring in function to fix numpydoc errors.
Any other comments?
#DataUmbrella sprint