Skip to content

DOC Ensures that recall_score passes numpydoc validation#21495

Merged
jjerphan merged 6 commits intoscikit-learn:mainfrom
embandera:np_v_has_fit_recall_score
Nov 5, 2021
Merged

DOC Ensures that recall_score passes numpydoc validation#21495
jjerphan merged 6 commits intoscikit-learn:mainfrom
embandera:np_v_has_fit_recall_score

Conversation

@embandera
Copy link
Copy Markdown
Contributor

Reference Issues/PRs

Addresses #21350
#DataUmbrella

This PR ensures recall_score is compatible with numpydoc:

  • Remove sklearn.metrics._classification.recall_score from DOCSTRING_IGNORE_LIST.
  • Verify that all tests are passing.

Copy link
Copy Markdown
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution.

balanced_accuracy_score : Compute balanced accuracy to deal with imbalanced
datasets.
multilabel_confusion_matrix : Compute a confusion matrix for each class or
sample.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly to https://github.com/scikit-learn/scikit-learn/pull/21479/files#r738422406 it might be worth to reference the plotting utilities here.

@ogrisel
Copy link
Copy Markdown
Member

ogrisel commented Oct 29, 2021

There is a also a conflict to solve: feel free to use the github web UI to fix it or ask for help if you do not understand what to do.

@ogrisel
Copy link
Copy Markdown
Member

ogrisel commented Oct 29, 2021

More specifically, the github conflict UI can be accessed by clicking:

resolve conflicts

It shows a single conflict:

image

This is caused by the fact that two neighboring lines have been deleted concurrently, both in a PR merged in the mean time to main and in this PR.

The resolution is to tell git that it's fine to delete both lines.

You can do so in the github UI. Don't forget to also delete the conflict markers (the lines with <<<<<<<, ======= and >>>>>>>) and then hit the: mark as resolved button.

Copy link
Copy Markdown
Member

@jjerphan jjerphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you, @embandera!

@jjerphan jjerphan merged commit 0003edf into scikit-learn:main Nov 5, 2021
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Nov 29, 2021
samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants