DOC Ensures that sklearn.metrics.pairwise.linear_kernel passes numpydoc validation#21470
Merged
glemaitre merged 6 commits intoscikit-learn:mainfrom Oct 30, 2021
Merged
Conversation
jjerphan
requested changes
Oct 27, 2021
Member
jjerphan
left a comment
There was a problem hiding this comment.
Hi @kondratyev-nv,
Thank you for this contribution!
Here are some suggestions.
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
jjerphan
reviewed
Oct 27, 2021
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
jjerphan
approved these changes
Oct 28, 2021
Member
jjerphan
left a comment
There was a problem hiding this comment.
LGTM, thank you, @kondratyev-nv, for this first time contribution!
ogrisel
approved these changes
Oct 29, 2021
Member
ogrisel
left a comment
There was a problem hiding this comment.
Thanks. Just a fix below: please commit the suggestion if you agree with it.
Careful, Julien. Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Member
|
Thanks @kondratyev-nv |
samronsin
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Nov 30, 2021
…oc validation (scikit-learn#21470) Co-authored-by: Julien Jerphanion <git@jjerphan.xyz> Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Dec 24, 2021
…oc validation (scikit-learn#21470) Co-authored-by: Julien Jerphanion <git@jjerphan.xyz> Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
glemaitre
pushed a commit
that referenced
this pull request
Dec 25, 2021
…oc validation (#21470) Co-authored-by: Julien Jerphanion <git@jjerphan.xyz> Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
For #21350
What does this implement/fix? Explain your changes.
pytest maint_tools/test_docstrings.py