Skip to content

DOC Ensures that train_test_split passes numpydoc validation#21435

Merged
glemaitre merged 1 commit intoscikit-learn:mainfrom
arisayosh:numpydoc_train_test_split
Oct 23, 2021
Merged

DOC Ensures that train_test_split passes numpydoc validation#21435
glemaitre merged 1 commit intoscikit-learn:mainfrom
arisayosh:numpydoc_train_test_split

Conversation

@arisayosh
Copy link
Copy Markdown
Contributor

Reference Issues/PRs

Addresses #21350

What does this implement/fix? Explain your changes.

  • removed sklearn.model_selection._split.train_test_split from scikit-learn/maint_tools/test_docstrings.py
  • edited docstring to address:
    • GL03: Double line break found; please use only one blank line to separate sections or paragraphs, and do not leave blank lines at the end of docstrings
    • SS03: Summary does not end with a period

Any other comments?

#DataUmbrella sprint
cc: @nestornav

@glemaitre
Copy link
Copy Markdown
Member

Perfect. Thanks @arisayosh

@arisayosh arisayosh deleted the numpydoc_train_test_split branch October 23, 2021 20:45
@arisayosh
Copy link
Copy Markdown
Contributor Author

Awesome, thank you for reviewing @glemaitre!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants