Skip to content

DOC Ensures that max_error passes numpydoc validation#21420

Merged
thomasjpfan merged 1 commit intoscikit-learn:mainfrom
arisayosh:numpydoc_validation
Oct 23, 2021
Merged

DOC Ensures that max_error passes numpydoc validation#21420
thomasjpfan merged 1 commit intoscikit-learn:mainfrom
arisayosh:numpydoc_validation

Conversation

@arisayosh
Copy link
Copy Markdown
Contributor

@arisayosh arisayosh commented Oct 23, 2021

Reference Issues/PRs

Addresses #21350

What does this implement/fix? Explain your changes.

  • remove sklearn.metrics._regression.max_error from scikit-learn/maint_tools/test_docstrings.py
  • fix numpydoc validation error in sklearn.metrics._regression.max_error

Any other comments?

cc (pair programming partner): @iofall

@arisayosh arisayosh changed the title DOC: fix numpydoc validation error in sklearn.metrics._regression.max_error DOC Ensures that sklearn.metrics._regression.max_error passes numpydoc validation Oct 23, 2021
@reshamas
Copy link
Copy Markdown
Member

#DataUmbrella sprint
cc: @nestornav

@amueller
Copy link
Copy Markdown
Member

Looks good if tests are passing :)

Copy link
Copy Markdown
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan changed the title DOC Ensures that sklearn.metrics._regression.max_error passes numpydoc validation DOC Ensures that max_error passes numpydoc validation Oct 23, 2021
@thomasjpfan thomasjpfan merged commit f93b97a into scikit-learn:main Oct 23, 2021
@arisayosh arisayosh deleted the numpydoc_validation branch October 23, 2021 20:46
@arisayosh
Copy link
Copy Markdown
Contributor Author

Amazing, thank you for reviewing @amuellar and @thomasjpfan. The sprint was such a fun learning experience! Thank you again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants