ENH Improves memory usage for standard scalar#20652
Merged
glemaitre merged 2 commits intoscikit-learn:mainfrom Aug 5, 2021
Merged
ENH Improves memory usage for standard scalar#20652glemaitre merged 2 commits intoscikit-learn:mainfrom
glemaitre merged 2 commits intoscikit-learn:mainfrom
Conversation
glemaitre
approved these changes
Aug 2, 2021
Member
glemaitre
left a comment
There was a problem hiding this comment.
LGTM. Thanks to have look at this issue.
jnothman
approved these changes
Aug 3, 2021
Member
jnothman
left a comment
There was a problem hiding this comment.
Great to have this fixed. I find it strange that nansum etc do not have more efficient implementation
samronsin
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Nov 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Closes #5651
What does this implement/fix? Explain your changes.
This PR:
np.meanandnp.nanmean. The nan mask is always computed when callingnp.nanmeantempvariable.Any other comments?
With the script in #5651:
And running on main and this PR:
I get the following plot:
Where the black line is this PR and the blue line is
main. We see that this PR reduces the compute time and memory usage.CC @jeremiedbb