DOC reformatting example as notebook style#20543
Merged
rth merged 7 commits intoscikit-learn:mainfrom Jul 19, 2021
Merged
Conversation
thomasjpfan
approved these changes
Jul 18, 2021
Member
There was a problem hiding this comment.
Thank you for the PR @glemaitre !
Minor comment on the figure sizing. Otherwise LGTM
examples/manifold/plot_lle_digits.py
Outdated
| # Finally, we can plot the resulting projection given by each method. | ||
| from itertools import zip_longest | ||
|
|
||
| fig, axs = plt.subplots(nrows=7, ncols=2, figsize=(15, 30)) |
Member
There was a problem hiding this comment.
To make the figures look a little better and fill up the space:
fig, axs = plt.subplots(nrows=7, ncols=2, figsize=(12, 24))
...
fig.tight_layout()
plt.show()Using zip_longest longest here is nice. :)
Member
Author
There was a problem hiding this comment.
Thanks I was indeed searching for the best sizing :)
samronsin
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Nov 30, 2021
Co-authored-by: Guillaume Lemaitre <glemaitre@Guillaumes-MacBook-Air.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #14226