DOC Ensures that CCA passes numpydoc validation #20504
DOC Ensures that CCA passes numpydoc validation #20504glemaitre merged 10 commits intoscikit-learn:mainfrom
Conversation
|
#DataUmbrella LATAM sprint |
|
It seems that there is another error with linting, but this time in another file (that you didn't modify). |
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
|
As mentioned in the original issue, item 3. (#20308), you need to remove the class from the |
glemaitre
left a comment
There was a problem hiding this comment.
I add the flag "Request changes" to tag that the PR has been reviewed.
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
I did that from the beginning, I would double check that it was removed. Thanks!! |
Removed CCA from the |
|
@napoles-uach What I needed was this change: 73fd5f5 I am not sure but it was not in your history. Maybe you did not commit or push your changes. Locally, the tests are passing so it should be OK and I will merge when all CIs will be green. |
OK 🤞 |
|
Merging. Looks good. Thanks @napoles-uach |
Thanks a lot @glemaitre 🙏 |
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Reference Issues/PRs
Addresses #20308
Data Umbrella sprint
What does this implement/fix? Explain your changes.
Errors in sklearn/cross_decomposition/_pls.py for CCA Class, e. g. GL07, PR08, SA04, RT01, RT04, RT05 among others.
Any other comments?