Skip to content

DOC Ensures that LassoLarsIC passes numpydoc validation#20465

Merged
glemaitre merged 51 commits intoscikit-learn:mainfrom
genvalen:LassoLarsIC
Jul 6, 2021
Merged

DOC Ensures that LassoLarsIC passes numpydoc validation#20465
glemaitre merged 51 commits intoscikit-learn:mainfrom
genvalen:LassoLarsIC

Conversation

@genvalen
Copy link
Copy Markdown
Contributor

@genvalen genvalen commented Jul 4, 2021

Reference Issues/PRs

Addresses #20308
#DataUmbrella Sprint

What does this implement/fix? Explain your changes.

Any other comments?

I included additional suggestions to the see also section.

genvalen and others added 30 commits June 6, 2020 16:02
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
genvalen and others added 21 commits June 10, 2020 17:57
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
@glemaitre
Copy link
Copy Markdown
Member

FYI: I think that should create a new branch by branching from main. It seems that you are branching from an older PR. For the moment this is fine because the diff is OK.

@glemaitre glemaitre merged commit 52cd5de into scikit-learn:main Jul 6, 2021
@glemaitre
Copy link
Copy Markdown
Member

Otherwise LGTM. Merging. Thanks @genvalen

@genvalen
Copy link
Copy Markdown
Contributor Author

genvalen commented Jul 7, 2021

@glemaitre thank you for your reviews! And yes, thank you for pointing out the branch. I will look into.

@genvalen genvalen deleted the LassoLarsIC branch July 7, 2021 17:31
samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
…#20465)

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants