DOC Ensures that OneClassSVM passes numpydoc validation#20463
DOC Ensures that OneClassSVM passes numpydoc validation#20463glemaitre merged 5 commits intoscikit-learn:mainfrom
Conversation
| **params : dict | ||
| Additional fit parameters. |
There was a problem hiding this comment.
To my knowledge, the fit function in the hierarchy of this class doesn't have any more parameters. Thus, params is not actually needed. Should we remove it?
There was a problem hiding this comment.
Yeah looks like it comes from BaseLibSVM. If you want you can check that passing any parameter actually raises an error, but it should be save to remove.
There was a problem hiding this comment.
I would do this change in another PR thought.
There was a problem hiding this comment.
Ok. When we are done with this PR, I will try to fix that in another PR.
|
Yeah. Once this PR get merged, these issues will be resolved. |
|
You need to document the property |
glemaitre
left a comment
There was a problem hiding this comment.
A couple of additional changes
| **params : dict | ||
| Additional fit parameters. |
There was a problem hiding this comment.
I would do this change in another PR thought.
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
|
Thanks for the comments @glemaitre. |
|
#20457 was merged. You can merge |
|
Thanks @jmloyola |
ensure SVDD passes numpydoc validation (scikit-learn#20463) check for svdd in `test_sparse.py:check_svm_model_equal` to avoid calling `.predict_proba`
ensure SVDD passes numpydoc validation (scikit-learn#20463) check for svdd in `test_sparse.py:check_svm_model_equal` to avoid calling `.predict_proba`
…#20463) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
ensure SVDD passes numpydoc validation (scikit-learn#20463) check for svdd in `test_sparse.py:check_svm_model_equal` to avoid calling `.predict_proba`
ensure SVDD passes numpydoc validation (scikit-learn#20463) check for svdd in `test_sparse.py:check_svm_model_equal` to avoid calling `.predict_proba`
ensure SVDD passes numpydoc validation (scikit-learn#20463) check for svdd in `test_sparse.py:check_svm_model_equal` to avoid calling `.predict_proba`
ensure SVDD passes numpydoc validation (scikit-learn#20463) check for svdd in `test_sparse.py:check_svm_model_equal` to avoid calling `.predict_proba`
Reference Issues/PRs
Addresses #20308
What does this implement/fix? Explain your changes.
This PR ensures OneClassSVM is compatible with numpydoc.
OneClassSVMfromDOCSTRING_IGNORE_LIST.Any other comments?
For this PR to pass all numpydoc test, this PR should be merged before.
#DataUmbrella Sprint