DOC Ensures that RFECV passes numpydoc validation#20452
Merged
glemaitre merged 11 commits intoscikit-learn:mainfrom Jul 7, 2021
Merged
DOC Ensures that RFECV passes numpydoc validation#20452glemaitre merged 11 commits intoscikit-learn:mainfrom
glemaitre merged 11 commits intoscikit-learn:mainfrom
Conversation
glemaitre
requested changes
Jul 6, 2021
Member
glemaitre
left a comment
There was a problem hiding this comment.
Could you merge main into your branch since that we will ignore the GL02 error.
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Member
|
We push a change to see how we can manage the docstring of the property. It seems that the way that pandas would be the best. |
Member
|
OK all good. Thanks @jaglima |
thomasjpfan
pushed a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Jul 7, 2021
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
samronsin
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Nov 30, 2021
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Addresses #20308
What does this implement/fix? Explain your changes.
Fixes numpydoc errors on RFECV functions.
Any other comments?
#DataUmbrella sprint
cc. @jaglima