DOC Ensures that VotingRegressor passes numpydoc validation #20450
DOC Ensures that VotingRegressor passes numpydoc validation #20450thomasjpfan merged 1 commit intoscikit-learn:mainfrom
Conversation
glemaitre
left a comment
There was a problem hiding this comment.
You need to remove VotingRegressor from the list of estimator located in maint_tools/test_docstring.py
|
Hi, thanks for reviewing. At first I removed it but since I did not know how to solve 2 failed I returned the change. One of the errors is: |
|
Around line 121, you need to add a docstring for the |
|
A thousand thanks. I added this text in 'named_estimators': """Object allows access any fitted sub-estimators by name."""" |
glemaitre
left a comment
There was a problem hiding this comment.
Could you merge main into your branch. It will solve the failure in the CI.
I added a suggestion to add the returned type for one of the property.
|
Thanks. Merged! |
|
@Anavelyz To fix the issue with |
|
About this comment @thomasjpfan, where do I find a guide to do it correctly? |
|
For your case: |
|
Ready! |
|
|
|
Something went wrong with the merge, would it be okay if I try to fix it for you? |
|
Yes, it's okay. Thank you! |
Reference Issues/PRs
References Addresses #20308
What does this implement/fix? Explain your changes.
Updated parameters and returned values descriptions.
Any other comments?
#DataUmbrella Sprint
cc: (pair programming partner) @marielaraj