Skip to content

DOC Ensures that MLPClassifier passes numpydoc validation#20444

Merged
glemaitre merged 3 commits intoscikit-learn:mainfrom
jmloyola:fix_numpy_mlpclassifier
Jul 6, 2021
Merged

DOC Ensures that MLPClassifier passes numpydoc validation#20444
glemaitre merged 3 commits intoscikit-learn:mainfrom
jmloyola:fix_numpy_mlpclassifier

Conversation

@jmloyola
Copy link
Copy Markdown
Member

@jmloyola jmloyola commented Jul 2, 2021

Reference Issues/PRs

Addresses #20308

What does this implement/fix? Explain your changes.

This PR ensures MLPClassifier is compatible with numpydoc.

  • Remove MLPClassifier from DOCSTRING_IGNORE_LIST.
  • Verify all tests passing.

Any other comments?

#DataUmbrella Sprint

Copy link
Copy Markdown
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glemaitre glemaitre merged commit adb7ced into scikit-learn:main Jul 6, 2021
@glemaitre
Copy link
Copy Markdown
Member

Thanks @jmloyola

@jmloyola jmloyola deleted the fix_numpy_mlpclassifier branch July 6, 2021 11:55
samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
…rn#20444)

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants